Nara fixes for amm - Githubissues

Joystream / joystream

Joystream Monorepo

http://www.joystream.org

GNU General Public License v3.0

1.42k stars 115 forks source link

Closed ignazio-bovo closed 7 months ago

ignazio-bovo commented 7 months ago

As agreed :

selling is not possible if the amm_provided_supply < amount_of_crt_to_sell
transaction fees from the amm are burned immediately
I have added a helper function on the numerical.rs utility library, I plan on adding more test, in the meantime the review can start

kdembler commented 7 months ago

~@ignazio-bovo sorry if it's a stupid question, but why does this PR result in changes in metadata?~

Edit: nevermind, that's because of new error type