search

Joystream / joystream

Joystream Monorepo
http://www.joystream.org
GNU General Public License v3.0
1.42k stars 115 forks source link

Add vested budget spending tests and mappings #5123

Closed thesan closed 7 months ago

thesan commented 7 months ago

Addresses https://github.com/Joystream/joystream/issues/5118

(Previous PR: https://github.com/ignazio-bovo/joystream/pull/15)

thesan commented 7 months ago

@zeeshanakram3 @mnaamani I think the build failed with

../../query-node/start.sh: line 11: docker-compose: command not found

https://github.com/Joystream/joystream/actions/runs/8542138020/job/23403106131?pr=5123#step:14:32047

Same thing for the network test build: https://github.com/Joystream/joystream/actions/runs/8542138019/job/23403409849?pr=5123#step:8:48

Has there been some changes to the runner ?

mnaamani commented 7 months ago

@zeeshanakram3 @mnaamani I think the build failed with

../../query-node/start.sh: line 11: docker-compose: command not found

https://github.com/Joystream/joystream/actions/runs/8542138020/job/23403106131?pr=5123#step:14:32047

Same thing for the network test build: https://github.com/Joystream/joystream/actions/runs/8542138019/job/23403409849?pr=5123#step:8:48

Has there been some changes to the runner ?

Yes I think it is quite possible the newer runners are installing newer versions of docker tools which do not include the docker-compose command, in favor of using docker compose sub command.

Perhaps we should update our scripts.

Strange in your other PR it works fine and it is using the same runner version https://github.com/Joystream/joystream/actions/runs/8551543087/job/23430768153?pr=5124#step:1:1

thesan commented 7 months ago

Strange in your other PR it works fine and it is using the same runner version https://github.com/Joystream/joystream/actions/runs/8551543087/job/23430768153?pr=5124#step:1:1

@mnaamani it looks like GH uses these new runners only sometime ATM.