search

Joystream / orion

Atlas backend
GNU General Public License v3.0
7 stars 15 forks source link

Missing notifications!!! #318

Closed bedeho closed 6 months ago

bedeho commented 6 months ago

I don't believe the NFT notifications are working properly, there was a bid that outbid me, but I received no notfication on email or in app, despite both being enabled in settings Screenshot 2024-03-14 at 18 38 48

Please also review if the CRT notifications really work also.

zeeshanakram3 commented 6 months ago

there was a bid that outbid me, but I received no notfication on email or in app, despite both being enabled in settings

I just checked the implementation and currently, no notifications are dispatched if someone outbids you in OpenAuction (since technically in the open auction your bid is still valid if a bid outbids you, and the NFT owner might still accept your bid despite having a higher offer)

It's just an implementation detail, but do let me know if we want to have notifications for Open Auction outbids.

bedeho commented 6 months ago

Wow, so fast! Yeah lets def add that, it still counts as a higher bid, which is what the notification text says above, and at any rate, this event is something we def. want to tell people about, including the current owner (which may or may not be the creator).