Count normal transfers as total channel revenue

[bedeho]

https://github.com/Joystream/atlas/issues/6271

[ikprk]

I assume that the fact that someone can boost their own total revenue by just transferring money to the channel rewards account and claim it in withdrawal over and over again is not a problem?

Afterwards, one can just create a token and be a top earner although this person might not even generate any revenue.

[mochet]

I assume that the fact that someone can boost their own total revenue by just transferring money to the channel rewards account and claim it in withdrawal over and over again is not a problem?

Afterwards, one can just create a token and be a top earner although this person might not even generate any revenue.

While this is indeed possible to do, there are also some highly creative uses of the CRT function being explored currently that would stand to benefit from this functionality:

1. https://gleev.xyz/channel/24503?tab=Token - my own creator token, as an experiment I will be putting the next 3 months of my staking rewards into it. It -should- already be the 7th highest CRT in terms of revenue and likely will be in the top 5 within 30 days.
2. I am currently negotiating a compensation package with the council, and if approved the compensation would be put into my CRT revenue account.
3. I have just presented a "Discretionary Community Building Fund" that would be issued as a CRT and receive funding from the council: https://pioneerapp.xyz/#/forum/thread/911 (this is not approved, but if approved would be a highly interesting use of the CRT feature)

So while the attack or manipulation you mention may be tried by some I think we will have to deal with it in the design of Atlas/Gleev (for instance: by showing the amount actually withdrawn from revenue splits) or some other ways

In any case, I believe people can just count transfers into the revenue account as "revenue" by using the extrinsic which attaches a remark to the TX. So it is trivial for bad actors to do this (although I am not 100% certain whether this is restricted to only the YPP account).

It is also possible for people to do wash or circular trading of NFTs and artificially inflate their channels revenue.

[mochet]

Just an update on this @bedeho @ikprk

There are now 2 CRTs for which this edge case applies:

• https://gleev.xyz/channel/24503?tab=Token (my own token, which should now be the 4th highest in terms of revenue and will continue rising in position)
• https://gleev.xyz/channel/64194?tab=Token (the Joystream Community Building Fund, which currently has 29k of revenue but will accrue 100k $JOY at minimum for the next 4 months and hopefully longer--this will likely make it the highest revenue token on Gleev within 45-60 days.

The revenue for both of these isn't registered and therefore they do not/will not show in the top CRTs and in other areas of the CRT marketplace.

So while these may still seem like edge cases, I feel it is important that this issue gets addressed because these are either already some of the highest revenue CRTs or will be and although edge cases can inject some much needed excitement/interest into the current CRT offerings.