Funding Request Proposal for Multiple Recipients

bwhm commented 2 years ago

Context

As can be seen below, the funding request proposal only allows a single recipient + amount. The use case often covers the need to execute bulk funding request paying multiple accounts different sums of money.

Screen Shot 2022-02-28 at 23 23 58

Designs

Link to Figma>

Scope

[ ] Update Create Funding Proposal with Multiple Recepients option
[ ] Update View Proposal
[ ] Test if Voting on this proposal works

Objective

Create Proposal:

[ ] Add "Pay multiple" toggle which when triggered addds a text are input
[ ] Add prompt on the format of adding accounts
[ ] Text are (text box) needs to have label "Destination accounts and transfer amounts"
[ ] Input must be provided in the CSV format: AccountAddress1, Amount; AccountAddress2, Amount; ⚠️ CSV file upload should not be supported we don't need extra effort to spend on this
[ ] Maximum allowed accounts is 20
[ ] Add "Preview and Validate" button underneath the input, that triggers the side drawer (see image) displaying Member ID as card (if account bound to member) and Amount

If "next" is clicked on proposal without preview show warning "Please preview and validate the inputs to proceed"

[ ] Use this card to display destination payments but change the label to "Amount to pay", instead of trasnferable balance; and Unknown Member isntead of "Unsaved account"
[ ] Add validation if "Max payment amount is exceeded" as yellow info box
[ ] Add validation if "Incorrect destination account added"

After preview is clicked

[ ] Display Total Payout in a info field on proposal input screen In case total payout exceeds the WG budget at the time of Proposal Creation, show warning.

Use this pattern for the execution violation case (the generic text is already implemented)

View Proposal

[ ] Add widget showing Current balance of Content WG
[ ] Add widget showing Total Payment
[ ] Add widget to view "Payment details" that slides drawer out (similar to how Signal proposal shows details:

More info

Feel free to use the below for inspiration:

┆Issue is synchronized with this Asana task by Unito

thesan commented 2 years ago

See https://github.com/Joystream/joystream/issues/4333 for the validation

sync-by-unito[bot] commented 2 years ago

➤ Dmitry Meltsov commented:

Design reqiured

traumschule commented 2 years ago

Moving this up a bit. Feel free to suggest designs, might give it a go.

dmtrjsg commented 1 year ago

👏 Designs are finished for this issue and its ready for dev @traumschule

Designs

Link to Figma>

Scope

[ ] Update Create Funding Proposal with Multiple Recepients option
[ ] Update View Proposal
[ ] Test if Voting on this proposal works

vrrayz commented 1 year ago

This is the progress i have made so far #4351

traumschule commented 1 year ago

For validation see this comment and updated runtime code. The restraint per beneficiary has been removed. Also note replacement of MAX_SPENDING_PROPOSAL_VALUE, MAX_VALIDATOR_COUNT, MAX_FUNDING_REQUEST_ACCOUNTS.

dmtrjsg commented 1 year ago

The council budget needs to be shown instead of Content WG budget. Discord link>

Joystream / pioneer