Joystream / pioneer

Governance app for Joystream DAO
https://pioneerapp.xyz/
GNU General Public License v3.0
44 stars 70 forks source link

Worker rewards sortable table to support better WG budgeting #3185

Open dmtrjsg opened 2 years ago

dmtrjsg commented 2 years ago

Context

WG representation of budgets + worker payments ⚠️ Queries behind data shown in some columns and originating ticket is here: https://github.com/Joystream/pioneer/issues/3180

Scope

Design a table view with Workers

Bedeho: Let me suggest concrete other values relevant to each worker that could be more useful

Add a new tab "Workers" to WG module which has all of the above.

mochet commented 2 years ago

An addition that is somewhat important:

This helps to explain the breakdown of "salaries" when considering lead vs worker

bedeho commented 2 years ago

From the original issue:

The view of each WG doesn't include a breakdown of workers with the amount they have been paid over the most recent council term. This makes tracking budgets extremely difficult. The only way to access this information otherwise is to click through each worker and see what their salary is.

This problems seems entirely an artifact of incentives v3, there is no inherent reason to focus on payments to anyone aligned with council periods in a realistic world. Its only because we have JOY earning schemes tied to this. I do not think this is wise to do at all.

There is sensible information to add associated with workers, like how much they earn, their reward rates, perhaps when they got the role, etc. But it's not clear we need a new table. Perhaps we do, but this rationale is not the reason for it, and the table columns reflect this incorrect prioritization of what problem is real vs. not.

bedeho commented 2 years ago

Let me actually be extra clear here:

I do actually think there is a sound case for a sort of deep overview of the workers involved, which could make sense in a table, because the right hand column is already quite cramped, I just want us to then focus on address genuine mainnet problems, not problems that artefactual to incentivesv3.

mochet commented 2 years ago

Based on further discussion it seems showing their rewards over the most recent council period term may be a bit arbitrary, it may make more sense to have the past week instead. Although a council is 1 week long now that could change and likely will.

bedeho commented 2 years ago

Let me suggest concrete other values relevant to each worker that could be more useful

Do we actually need anything else under real world conditions?

Also, its not clear to me where it was meant for this all to be, but seems we can just have a new tab "Workers" which has all of this.

I am not even sure a table is the best UX here, but the whole app is already in that mode, so perhaps easiest to just stick with it.