Joystream / pioneer

Governance app for Joystream DAO
https://pioneerapp.xyz/
GNU General Public License v3.0
44 stars 68 forks source link

[USERSNAP] Data shown on TOTAL SPENT column is strange #3260

Open dmtrjsg opened 2 years ago

dmtrjsg commented 2 years ago

Taken at: https://dao.joystream.org/#/council/past-councils Fields:

SCREENSHOT Download original image

Browser: Chrome 102 (macOS Catalina) Screen size: 1512x982 Browser size: 1512x780 Open #284 in Usersnap

Powered by Usersnap.

dmtrjsg commented 2 years ago

@singulart is this suggestion to expose particular spending categories (if so, which ones would make most sense?) or look into the logic behind the numbers here?

dmtrjsg commented 2 years ago

After having a look: on the FE we don't do any calculations. We get it from QN (Event name = budget_spending) and its all money spent by Council.

@singulart over to you on what's a preferred target state. Pls feel free to reply here or ping me in DM on discord. Thank yoU!

singulart commented 2 years ago

@mochet WDYT?

dmtrjsg commented 1 year ago

@mochet ping :)

dmtrjsg commented 1 year ago

@mochet pls advise on the above

traumschule commented 1 year ago

Since total means everything it has to be complete to be useful: 1.Column Total spent: Councilor rewards, Channel payments, Funding requests, WG minting

  1. WGs Minted / Refilled: Allocated to WG, can be higher than actual spending. It makes sense to separate between WG refills (budget allocation) and actual minting events (rewardPaid, discretionary spending).
  2. Hide spent on proposals because it's almost always zero.
  3. Drop Proposals rejected to save space

Icing:

For illustration see the current Council budget plan:

position amount
Councilor rewards 250,560
Funding proposals 0
Creator payout rewards 0
Other allocations 0
Council minting subtotal 250,560
Start Council budget 52,646,605
Term Increment 5,499,990
WG allocation 1,700,900
End Budget 56,195,135

From the handbook: https://handbook.joystream.org/system/council#budget

Notice that working group spending, such as lead spending, or subsystem specific spending, such as minting initial credit for invited new members, does not directly count against the council budget, but against the relevant working group budget.