Create validator profile

[dmtrjsg]

Context

• https://github.com/Joystream/pioneer/issues/4321

Design

🆕 Link to Figma>

Design Preview

Scope

Add section to create membership modal for validators.

• [ ] Toggle: I am validator. By default set to "no". When set to Yes adds more fields to the form
• [ ] Stash account(s) or Validator Controller account(s) binding ⚠️ These fields will go to membership metaprocol and we need to add these fields to QN
• [ ]Add tooltips
• [ ] Status will be "Unverified by default"

⚠️ When validator account added, the membership creation tx has additional step - binding account to membership. This happens before Membership is created/ updated (as a first step in the tx)

⚠️ Pls make sure that all form inputs validation are done in accordance to the full scnearios of user story

• Binding multiple accs at once
• Insufficient balance
• Wrong acc address pasted
• Signing the binding tx with correct account (stash or validator controller)

ℹ️ Verification is covered in this story:

• https://github.com/Joystream/pioneer/issues/4334

[dmtrjsg]

@chrlschwb designs are finalised

[eshark9312]

@dmtrjsg Binding validator account tx can't be done before creating a membership.

As @thesan mentioned here, binding validator account with the membership is the same as binding any staking account, and there is no specific parameter for the validator staking account to differentiate it from other staking accounts which are used for other activities like Add New Proposal. Same for nominators.

I suggest to change the design.

• We can add Add validator account button like in nominators page, or preferably Bind staking account.
• This operation needs two transaction: members.addStakingAccountCandidate first, then members.confirmStakingAccount. So two-step modal should be used here.
• Also we can add Edit bound accounts part in EditMembershipModal. There will be three types of staking accounts: validator accounts, nominator accounts and other staking accounts, and user can select the accounts to remove from the membership. And there is the Bind staking account button too.

[dmtrjsg]

Hey @eshark9312 thank you for raising this!

1️⃣ Why cannot we add validator accounts to bind in the same flow as creating membership? but just sign "creating" tx first in the multi-step of the tx modal? So we would have 3 steps when membership is created and same for updated?

2️⃣ For a more effective management of all bound accounts, I really like your idea, but this could be added later, right? As an improvement.

Let me know if I am missing smth.

cc @thesan

We will discuss and I will come back to you with details.

[eshark9312]

@dmtrjsg

1️⃣ Why cannot we add validator accounts to bind in the same flow as creating membership? but just sign "creating" tx first in the multi-step of the tx modal? So we would have 3 steps when membership is created and same for updated?

-It can be done, but needs three step tx. -creating tx should be first. -From the current design, a member can add validator account by update membership modal, but he can add nominator account in validator/nominator page even though they are equal operation. That's the point.

[dmtrjsg]

@eshark9312 Thanks for the clarification, pls see the responses below.

Validator acc binding: step 1 - first part of binding step 2 - is to confirm but can be batched with account creation of membership

Nominator: Here the account is not actually bound with the account Add nominator account - any account can be added (no signature is required) Create stash account - aka set up new bonding preferences - this does not have to be signed with the membership controller account so case is slightly different to binding the validator acc (we do not strictly require to view members in context of nominators, but if controller account is the same for nominator stash and membership - then we surely can!)