RWD Bugs

[ivanturlakov]

Perhaps here we can hide the second column so that the third column is readable

[ivanturlakov]

Also on mobile no chance to view tooltips(?), not critical but maybe an easy solution could be found.

The wide fixed-width elements that now have a horizontal scroll are hard to read on mobile devices, maybe we can just hide(or rearrange) some elements inside to get rid of the scroll?

[dmtrjsg]

@ivanturlakov great that you raised it as a separate issue. So the fixes also can come in separate PR instead of changing the existing HUGE pr 👍

@eshark9312 pls kindly address it in a separate pr.

[chrlschwb]

@eshark9312 this issue was already addressed in https://github.com/Joystream/pioneer/pull/4607. What is the status now? Will you create a separate PR?

[eshark9312]

@chrlschwb Yes, addressed in #4607 and passed all QA tests.

[ivanturlakov]

@eshark9312 Looks like were missed this

[eshark9312]

@ivanturlakov I've fixed it just before. Please check again. https://dao-737dtg4ng-joystream.vercel.app/#/proposals/preview/626

[thesan]

@chrlschwb Yes, addressed in #4607 and passed all QA tests.

@eshark9312 as @dmtrjsg wrote in this https://github.com/Joystream/pioneer/issues/4609#issuecomment-1792264311 please address issues reported here in a separate PR, not in #4607 because this PR is starting to grow to big with changes unrelated to election, forum nor settings.

So until #4607 gets merged please address the QA feedback on a different branch based on rwd/election,forum-and-settings but that you can rebase after #4607 is merged.

[thesan]

The proposal empty state is no longer centered:

[thesan]

According to the new designs every pages main content should be centered in an at most 1150px wide container:

[thesan]

The members table headers are misaligned with the table content:

[ivanturlakov]

Menu link active state Cards layout

Design

[eshark9312]

@ivanturlakov Please check here.

[ivanturlakov]

@eshark9312 Looks good thank you!

One more thing

[eshark9312]

I fixed it. https://dao-p59ur48rn-joystream.vercel.app/

[kdembler]

So so great to see this live and browse on mobile!

2 observations:

1. The content now doesn't take full page width anymore, I guess that's an expected change? Before: https://share.cleanshot.com/J7fXnR4d After: https://share.cleanshot.com/W5427Ctb
2. The selected tab underline now floats slightly above the bottom border Before: https://share.cleanshot.com/r1WTJ4b9 After: https://share.cleanshot.com/WZdV6ytC

[dmtrjsg]

@kdembler looks like legit bugs to me, @eshark9312 would you like to address the comments from Klaudiusz as well?

[chrlschwb]

So so great to see this live and browse on mobile!

2 observations:

1. The content now doesn't take full page width anymore, I guess that's an expected change? Before: https://share.cleanshot.com/J7fXnR4d After: https://share.cleanshot.com/W5427Ctb
2. The selected tab underline now floats slightly above the bottom border Before: https://share.cleanshot.com/r1WTJ4b9 After: https://share.cleanshot.com/WZdV6ytC

1. That's an expected change.
2. I think that was missed during the QA. @eshark9312

[eshark9312]

1. That's what is required from design.
2. I fixed this on https://github.com/Joystream/pioneer/pull/4636.