search

Joystream / pioneer

Governance app for Joystream DAO
https://pioneerapp.xyz/
GNU General Public License v3.0
44 stars 69 forks source link

📡 Add support for WalletConnect #4759

Closed thesan closed 6 months ago

thesan commented 7 months ago

Partially address:

> preview

Designs: Wallet selection Membership creation

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Feb 22, 2024 0:54am
pioneer-2 ✅ Ready (Inspect) Visit Preview Feb 22, 2024 0:54am
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Feb 22, 2024 0:54am
thesan commented 6 months ago

This PR is already way too big so I changed the target to a new branch wallet-connect branch so this can be merged before this whole feature is stable, i.e wallet connect support and better mobile support.

thesan commented 6 months ago

@kdembler

disconnecting a wallet in Pioneer doesn't end WC session.

I just fixed this.

FYI there was a change on this PR to show the member selection modal with the "Disconnect wallet" button when you click on "Join Now". However it was bundled with a lot of UI changes so I moved everything to #4781 (to have a more manageable PR size). So until we get to #4781, if you connect with a wallet with no memberships you can disconnect the wallet by clicking on "Add New Proposal".