Joystream / pioneer

Governance app for Joystream DAO
https://pioneerapp.xyz/
GNU General Public License v3.0
44 stars 68 forks source link

Working group "About" tab description and routing #4771

Closed Ilichhh closed 5 months ago

Ilichhh commented 5 months ago

The working "About" tab is empty (for all working groups) #4654

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Feb 14, 2024 11:58am
pioneer-2 ✅ Ready (Inspect) Visit Preview Feb 14, 2024 11:58am
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Feb 14, 2024 11:58am
Ilichhh commented 5 months ago

My suggestion here was wrong since the WorkingGroup component is now actually the About tab. What you implemented instead works but it duplicates a lot of code for testing just one page.

Instead I replaced WorkingGroup by WorkingGroupsModule which works more like the original suggestion. But I wanted to make sure it worked first so I committed it myself.

The rest LGTM !

Cool, thanks!
But you just removed some gql.queries that I added, and wornings on History and Openings tabs appears again. I don't think they're really needed since they contain empty data. Plus other stories also have a lot of missing gueries and there are wornings. Just want to clarify this point for better understanding for the future.