Joystream / pioneer

Governance app for Joystream DAO
https://pioneerapp.xyz/
GNU General Public License v3.0
44 stars 68 forks source link

📢 Add support for role mentions #4789

Closed thesan closed 4 months ago

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Mar 4, 2024 8:22am
pioneer-2 ✅ Ready (Inspect) Visit Preview Mar 4, 2024 8:22am
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Mar 4, 2024 8:22am
thesan commented 4 months ago

Hey @ivanturlakov I deployed this version of the backend at: https://api-rul8.onrender.com it's pointed to Mainnet.

On this PR preview: https://dao-git-feature-dao-roles-support-joystream.vercel.app/ could you please replace the backend url on the custom network and then:

If this goes I think that's enough QA for this feature.

ivanturlakov commented 4 months ago

Tested on https://dao-git-feature-dao-roles-support-joystream.vercel.app/#/forum/thread/875 Mainnet, Backend https://api-rul8.onrender.com

My email(Gmail) address was not linked and the app asked me to add it, the confirmation email went to the spam folder. I confirmed the email and my address appeared in Settings > Notifications

I created a new thread and tagged Builders

Screenshot 2024-03-05 at 15 54 21

I added a post to the thread and tagged DAO

Screenshot 2024-03-05 at 16 02 15

It's been 3 hours so far and I haven't received any notifications yet(including spam folder)

thesan commented 4 months ago

@ivanturlakov thank you for checking. It was the issue reported by @kdembler (I had fixed it already but forgot to redeploy :facepalm:). About the spam it's probably just Gmail seeing my personal address used to send transactional emails (nothing to do with the code).

Please check again when you can.

ivanturlakov commented 4 months ago

I just got the notifications, links is correct

for Builders

Screenshot 2024-03-05 at 19 20 52

for Dao

Screenshot 2024-03-05 at 19 21 05