Joystream / pioneer

Governance app for Joystream DAO
https://pioneerapp.xyz/
GNU General Public License v3.0
44 stars 70 forks source link

🧾 Fix past council Total Spent #4831

Open thesan opened 5 months ago

thesan commented 5 months ago

Addresses #4823

This gets rid of the funding requests which didn't execute: rejected, slashed, failed execution, etc...

It also counts a funding requests expense in the spending of the council which approved it, regardless of when the proposal execute. If the funding requests constitutionality was to be raised, the last council would be attributed the spending. Similarly proposal which are still gracing are also included to the spending (if the proposal execution fail the spending of the council which approved it would decrease).

Here's the result: https://dao-git-fix-past-council-total-spent-joystream.vercel.app/#/council/past-councils Screenshot from 2024-04-11 19-18-00

@dmtrjsg do you know who could double check this ?

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
dao ✅ Ready (Inspect) Visit Preview Apr 11, 2024 6:52pm
pioneer-2 ✅ Ready (Inspect) Visit Preview Apr 11, 2024 6:52pm
pioneer-2-storybook ✅ Ready (Inspect) Visit Preview Apr 11, 2024 6:52pm