🦊 Metamask integration POC

Joystream / pioneer

Governance app for Joystream DAO

https://pioneerapp.xyz/

GNU General Public License v3.0

44 stars 68 forks source link

🦊 Metamask integration POC #4835

Closed thesan closed 1 week ago

thesan commented 2 months ago

Demo

@chainsafe/polkadot-snap fails on FF for me so the demo only works on Chrome based browsers AFAIK.
~~The demo points at my publish version of the snap, so it only works with Metamask Flask.~~
The snap works with HTTP RPC endpoints only (adding WS support is a headache). So the Apps implementing this should start storing the HTTP RPC link too. ~~In the meantime it works with a simple text replacement hack.~~ Done :heavy_check_mark:

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
dao	✅ Ready (Inspect)	Visit Preview	Jun 27, 2024 3:01pm
pioneer-2	✅ Ready (Inspect)	Visit Preview	Jun 27, 2024 3:01pm
pioneer-2-storybook	✅ Ready (Inspect)	Visit Preview	Jun 27, 2024 3:01pm

thesan commented 2 months ago

@kdembler the official snap seems to work now but it still reports an error when connecting. Also I it might have been working before the last release, but I was focussed on this error before realizing that the wsRpcUrl should actually be the http rpc url :confused:.

I reported the issue (with the error message): https://github.com/ChainSafe/metamask-snap-polkadot/issues/231

Going forward:

Some more QA is needed especially with the real (i.e not flask) Metamask and with extrinsics that are Joystream specific.
The apps supporting this should store the http rpc endpoints in addition to the ws one.
Also maybe this should be enabled on Chrome based browser only for now. I had forgotten about this and got confused on FF today :facepalm:

thesan commented 1 month ago

@kdembler I now get the 0.9.0 version of the snap with MetaMask:

However it still doesn't work on FF for me. I get to this screen but nothing happens: Can you confirm it works for you on FF ?

kdembler commented 4 weeks ago

Walletconnect seems to not work for me after this change. When I select the option, I don't get the connect popup

thesan commented 2 weeks ago

Walletconnect seems to not work for me after this change. When I select the option, I don't get the connect popup

@kdembler I think this is because the wallet connect project from JSG got verified so it won't work on the preview branches anymore. The popup does appear eventually, but the connection doesn't work and this error appears in the console a bunch:

So I changed REACT_APP_WALLET_CONNECT_PROJECT_ID on the pioneer-2 Vercel deployment and it now works on: https://pioneer-2-git-feature-metamask-snap-joystream.vercel.app