Joystream / status-endpoint-joystream

Status endpoint for the Joystream network
GNU General Public License v3.0
1 stars 4 forks source link

Add total supply endpoint #37

Closed DzhideX closed 1 year ago

DzhideX commented 1 year ago

This PR aims to implement the total supply endpoint on the status server.

Notes:

mnaamani commented 1 year ago
  • I also thought about returning totalSupply from api.calculateCirculatingSupply as we already fetch that there as a way to optimize the fetching process but thought it'd sacrifice the modularity/readability(?) so decided against it. I'll defer judgment here and I am fine with either way.

Yes I would have gone for this approach also, but your implementation required no refactoring so it was quick and easy to review. So I'm happy with this.

Tested and works as expected.