Joystream / substrate-node-joystream

Joystream Full Node
https://www.joystream.org
GNU General Public License v3.0
15 stars 16 forks source link

Select a proper ProtocolId in genesis block #69

Closed mnaamani closed 4 years ago

mnaamani commented 5 years ago

We should ideally select a unique protocolId to configure for joystream network, especially if it also helps with #68

Consider how it impacts client side code, and ss58 encoding of addresses.

mnaamani commented 4 years ago

We now use a unique protocol id in our default config builder.

of the form "/joy/testnet/N"

Where N is a number. It is good practice to bump N when launching a new chain to avoid connections being established between different networks.

Also the protocolId is a low level libp2p networking parameter that has no bearing on the address prefix used for ss58 encoding of addresses. That is an application level concept.