Closed rllola closed 7 years ago
This error is actually being catch by detail::subroutine_handler::CreateGenericHandler
so the errors are never throw into any alerts but are thrown in the callbacks which means that if we recieve the alert is that no error has occured.
When in
startDownloading
we never checked if it throw error https://github.com/JoyStream/extension-cpp/blob/master/sources/src/TorrentPlugin.cpp#L478See doc in protocol_session :
We should try to catch them and add an error in the
startDownload
alert so the electron app can use this error.