JoystreamClassic / extension-cpp

C++ libtorrent extension library
MIT License
0 stars 3 forks source link

Hardcoded lower bound download rate to seller timeout #48

Open mnaamani opened 6 years ago

mnaamani commented 6 years ago

We are imposing a minimum download rate on sellers of approximately 10KB/s before we consider them to be too slow and disconnect them. This is handled in the session by putting an upper bound on how long a seller should take to deliver a full piece.

Is this really a good idea after all? What if a torrent swarm is only made of joystream peers and all are serving the torrent at a low download rate. The buyer could find themselves constantly restarting paid downloads looking for better results.

In such cases it would be more flexible to allow the application to set this limit, or optionally disable it all together.

Solution: Add plugin requests to be able to change the limit or disable the timeout feature completely.