WIP - libtorrent interaction

JoystreamClassic / extension-cpp

C++ libtorrent extension library

MIT License

0 stars 3 forks source link

WIP - libtorrent interaction #7

Closed mnaamani closed 7 years ago

mnaamani commented 7 years ago

WIP

[x] Fix return value in peer_plugin message handlers
[x] Add plugin request to change libtorrent interaction mode
[x] do not interfere with libtorrent choking/unchoking mechanism (it can lead to peers being in inconsistent state). It is sufficient to implement on_request and write_request peer plugin methods to prevent libtorrent sending piece requests, and processing piece requests.

mnaamani commented 7 years ago

@bedeho Ready for review

I decided to avoid sending choke/unchoke messages and avoid interfering with libtorrents mechanism.

Reading about upload_mode it doesn't appear to be the best way to prevent downloading, because it also depends on the torrent not to be auto-managed. It meant to be more of a temporary state to

It is sufficient and most straight forward to override on_requeset and write_request to achieve the desired LibtorrentInteraction.