search

Jpadilla1 / react-native-ios-charts

Bringing iOS Charts to React Native
MIT License
588 stars 68 forks source link

When the updated Charts to 3.0.0, Xcode will build failures #65

Open 0xashu opened 7 years ago

0xashu commented 7 years ago

When I through the pod update Charts to version 3.0.0, Xcode build will produce thereact-native-ios-charts related errors. It is possible that the react-native-ios-charts didn't keep up with the Charts 3.0.0 updates.

alexkendall commented 7 years ago

+1

ghost commented 7 years ago

+1

mahlon-gumbs commented 7 years ago

@Aaaaaashu did you ever get this resolved? If so, can you share what you did?

0xashu commented 7 years ago

@mahlon-gumbs we fork Charts swift 3.0 branch to use

mahlon-gumbs commented 7 years ago

@Aaaaaashu that did the trick. Thanks.

xzyaoi commented 7 years ago

I think i still met this problem... don't know why

** BUILD FAILED **                                                                                                                                    

The following build commands failed:                                                                                                                  

        CompileSwift normal x86_64 /Users/Apple/Documents/code/foodie/node_modules/react-native-ios-charts/RNiOSCharts/BarLineChartViewBaseExtension.s
wift                                                                                                                                                  
        CompileSwift normal x86_64 /Users/Apple/Documents/code/foodie/node_modules/react-native-ios-charts/RNiOSCharts/RNBarChartManager.swift        
        CompileSwift normal x86_64 /Users/Apple/Documents/code/foodie/node_modules/react-native-ios-charts/RNiOSCharts/RNHorizontalBarChartManager.swi
ft                                                                                                                                                    
        CompileSwift normal x86_64 /Users/Apple/Documents/code/foodie/node_modules/react-native-ios-charts/RNiOSCharts/RNBubbleChartManager.swift     
        CompileSwift normal x86_64 /Users/Apple/Documents/code/foodie/node_modules/react-native-ios-charts/RNiOSCharts/RNScatterChartManager.swift    
        CompileSwift normal x86_64 /Users/Apple/Documents/code/foodie/node_modules/react-native-ios-charts/RNiOSCharts/RNRadarChartManager.swift      
        CompileSwift normal x86_64 /Users/Apple/Documents/code/foodie/node_modules/react-native-ios-charts/RNiOSCharts/RNCandleChartManager.swift     
        CompileSwift normal x86_64 /Users/Apple/Documents/code/foodie/node_modules/react-native-ios-charts/RNiOSCharts/chartDataHelpers.swift
wuxudong commented 7 years ago

I fork this repo, and update Charts to newest version V3. you can check it at https://github.com/wuxudong/react-native-ios-charts

I have no experience of coding with swift & oc, so I can only fix compile error based on google and xcode hint. It took me hours.

It seems work.

btw: there is lot code duplications in this repo. need to be refactor.