search

Jroland / kafka-net

Native C# client for Kafka queue servers.
Apache License 2.0
483 stars 232 forks source link

Support version 0 (zookeeper) and version 1 (kafka) protocol for commit offsets. #48

Open nrandell opened 9 years ago

nrandell commented 9 years ago

Basic support working and unit tests running ok.

One unit test fails though - ProducerConsumerIntegrationTests - ConsumerShouldMoveToNextAvailableOffsetwhenQueryingForNextMessage is failing, but I don't think this is related.

Jroland commented 9 years ago

Nice Ill have a look

Jroland commented 9 years ago

@nrandell do you have a consumer written that is implementing the ConsumerCoordinator offset management APIs? Or was this patch just to get the offset commits working with 8.2?

nrandell commented 9 years ago

This was just to get the commits working. On 2 Apr 2015 10:27 pm, "James Roland" notifications@github.com wrote:

@nrandell https://github.com/nrandell do you have a consumer written that is implementing the ConsumerCoordinator offset management APIs? Or was this patch just to get the offset commits working with 8.2?

— Reply to this email directly or view it on GitHub https://github.com/Jroland/kafka-net/pull/48#issuecomment-89049404.

Jroland commented 9 years ago

@nrandell i have pulled this in to the integration branch. But I don't have a kafka 8.2 to test it against. I'll get it setup and tested on Tuesday. I think I need to start writing up some actual documentation for this now too. Specially with multiple versions coming out.