Js-Brecht / gatsby-plugin-pnpm

Provides PNPM compatible module resolvers to Webpack for Gatsby
MIT License
48 stars 6 forks source link

Inline framework packages and check for react-dom/server usage #19

Open danilobuerger opened 1 year ago

danilobuerger commented 1 year ago

The framework test was changed in gatsby 5.6 via https://github.com/gatsbyjs/gatsby/pull/37508

Therefor framework.test is no longer of type RegExp and fixFrameworkCache would return early. This resulted in the non-creation of framework-[contenthash].js. Instead the framework was then located in app-[contenthash].js

Since I didn't find a good way to get the framework bundles, I just inlined them from the gatsby repos. They were not changed since 2020 (the creation of the framework chunking). So this seems pretty stable.

Further this now checks for react-dom/server and does not include it in the framework bundle as done in the main gatsby repos by PR linked above.

\ cc @LekoArts Maybe you have the time to quickly glance over this?