Closed muuvmuuv closed 3 years ago
It's just a peer dependency warning. I can't imagine the upgrade will affect this plugin, unless they've changed the webpack config api. Webpack 5 accepts aliases/module resolvers the same way Webpack 4 does, so I think this should be good.
Once I have an opportunity to upgrade some projects to Gatsby v3 and make sure everything works, I can come back and update the peer dependency. Until then, if somebody can verify it is working or if anything breaks, please let me know
I attempted the upgrade a few days ago. I found that react-fast-refresh
was crashing afterward and pages wouldn't hot reload. I have no idea if this is pnpm problem or not, but I didn't see it reported in the main Gatsby issues page, and this is one of the more unusual parts of my configuration, so I thought I would note it.
@gchallen Can you share a reproduction?
Yeah, sorry, I suck, no. At least not quickly. My project is a big ugly poorly-organized monorepo.
I'll keep trying to upgrade once I see some additional changes to the Gatsby sources. Feel free to ignore at this point.
Actually this seem like it's been reported on the main Gatsby issues page now with 3.0.0+. So very likely not related to pnpm. I should have figured 😄. Sorry for the spam.
As far as I can see, it does work without problems.
Published in v1.2.6
Gatsby released version 3 recently. It now prints this warning. I could not test if this plugin still works since I am doing a huge rewrite of my project but maybe someone else can.