search

JsCommunity / json-rpc-peer

JSON-RPC 2 transport-agnostic library
13 stars 3 forks source link

TypeScript Support #50

Closed huan closed 3 years ago

huan commented 6 years ago

I think we should also convert the code base of this module from JavaScript to TypeScript too because we had already done JsonRpcProtocol: https://github.com/JsCommunity/json-rpc-protocol/issues/30

julien-f commented 6 years ago

Like list time, I'm open to a PR :slightly_smiling_face:

huan commented 6 years ago

Ok, like list time, I'll make it. :)

huan commented 6 years ago

Hi @julien-f,

Good weekend.

I had submitted a PR(#56) that convert the code base to the TypeScript, please have a look when you have time.

Thanks.

huan commented 6 years ago

ping @julien-f

julien-f commented 6 years ago

Hi,

I've seen your PR but I have very little time between my job and the holidays, I'll have more time in a couple of months.

If you really are in a hurry, you can publish a temp fork on npm :slightly_smiling_face:

huan commented 6 years ago

No, I'm not in a hurry, no rush at all.

Just want to confirm that this issue has not been forgotten, and please take your time and feel free to let me know if I need to something.

BTW: I'd like be a volunteer to help you maintain the json-rpc projects when you need any collaborator.

huan commented 5 years ago

@julien-f Did you get time to review this PR for now? :)

huan commented 5 years ago

Hello @julien-f

I hope you are doing well!

This PR had been held for months, could you please take some time to have a look on it, and it would be fantastic if it could be merged because we will get better TypeScript support for the project!

Thank you very much.

maxhawkins commented 4 years ago

I'd love to see this merged!

maxhawkins commented 4 years ago

I added a PR that adds typescript definitions rather than converting the project to typescript