JsCommunity / json-rpc-peer

JSON-RPC 2 transport-agnostic library
13 stars 3 forks source link

Suggestion: generate rpc id from cuid instead of a int number #55

Open huan opened 6 years ago

huan commented 6 years ago

Currently, we are using a very large negative number as the rpc id, and each time increase by one.

There's another way to generate unique id by using cuid: http://npmjs.com/package/cuid

Personally, I'm using cuid a lot, so I'd like to suggest we use cuid to generate our Peer rpc id too.

If you agree to use cuid, I'll make it in my pull request.

julien-f commented 6 years ago

I know cuid but I'm still undecided.

Anyway it should be part of a separate PR, not mixed up with a TypeScript rewriting :slightly_smiling_face:

huan commented 6 years ago

Ok, I'll make it in another PR and let's decide later.