search

JsCommunity / json-rpc-peer

JSON-RPC 2 transport-agnostic library
13 stars 3 forks source link

Refactor code base to TypeScript (fix #50) #56

Open huan opened 6 years ago

huan commented 6 years ago

Convert the code base to TypeScript #50

huan commented 6 years ago

ping @julien-f

alexstrat commented 5 years ago

@julien-f any chance to see this merged?

julien-f commented 5 years ago

Hey everybody,

I don't think I will merge this, I'm not proficient enough in TypeScript to feel confident in changing the current code to it.

My experience with json-rpc-protocol (which is much simpler) is mixed: since the move to TS I feel uneasy making some changes which would have been trivial in JS just because I don't know to do it without breaking the types.

I am open to adding a declaration file though :slightly_smiling_face:

@huan Thank you so much for your work and I'm sorry for doing this so late.

huan commented 5 years ago

@julien-f That's ok for me, thanks for telling me that.

And please feel free to let me know when you want to switch to a TypeScript code base! :)