search

JsKingBoo / SableyeBot3

Competitive Pokemon Discord Bot
8 stars 7 forks source link

Change `//filter` output when nothing matches. #14

Closed Stalruth closed 4 years ago

Stalruth commented 4 years ago

//filter now outputs a message informing a user that there are no matches and a --threshold argument to use if they want partial matches.

Just wanted to run this by you first as this is a significant change in behaviour.

I reckon this is a more user friendly experience than (worst case) Direct Messaging the user, forcing them to click out of the channel they're in only to find there are no matches - especially when the output is relevant to channel conversation. (Example command: //filter type=dark, type-bug)

Even where it posts to the channel there have been cases where people have been confused because they don't notice the disclaimer that no Pokemon satisfy all search criteria - removing the list of partial matches entirely when not requested would clear this up.

and yeah its a bit odd that i make a pr for this but not for the last big change to //filter oops

JsKingBoo commented 4 years ago

Looks good. Thank you for your contributions.