search

JsKingBoo / SableyeBot3

Competitive Pokemon Discord Bot
8 stars 7 forks source link

Errors in README.md regarding fresh installation #6

Closed Stalruth closed 5 years ago

Stalruth commented 5 years ago

There are two issues in README.md with respect to a fresh installation of the bot.

  1. The Pokemon Showdown Server needs to be built first (./build) for the files needed from sim/ to be generated.

  2. As of Zarel/Pokemon-Showdown-Client@84e76c :

    Stop tracking minidex in Git

    These files are now autogenerated by the build scripts, and depend on files not even present on GitHub anyway.

    (The minidex is a database of height/width for PS's animated GIF sprites, for use by the animation engine. It also contains dex numbers for use by pokemon icon spritesheets.)

    This means that //sprite and //furretturretsprite won't work off a fresh install.

JsKingBoo commented 5 years ago

uh oh I don't know how to fix this

Well actually I do have a vague idea, I need to generate them myself. I only depend on the existence of the female flag IIRC. Alternatively I can hijack the build script. Not sure how I want to approach this at the moment.

Stalruth commented 5 years ago

Alrighty so downloading the Client and doing a full build solves getting the files from the sim/ directory of the server, as the full build downloads and builds the server, although the js files are locates in Client_dir/data/Pokemon-Showdown/.sim-data.

Getting the sprites is a slightly thornier issue. You could download the sprites from here (XY) and here (BW) but then you might as well download pokedex-mini.js and its BW version manually. The alternative is to change the //sprite and //furretturretsprite commands to check for the existence of female sprites, which is likely a better call.

Stalruth commented 5 years ago

I've been looking at //sprite for some time and the best solution is probably to download the files from https:play.pokemonshowdown.com as the structure of the commands seems to not be friendly to async functions, which is the only other way I can see this working.

JsKingBoo commented 5 years ago

Fixed by #7