search

JsSucks / BetterDiscordApp

Better Discord App enhances Discord desktop app with new features.
MIT License
589 stars 117 forks source link

[Bug] CSS editors don't open at all. #337

Open FrobtheBuilder opened 5 years ago

FrobtheBuilder commented 5 years ago

Describe the bug Neither the custom editor nor system editor buttons in the CSS editor menu seem to actually do anything at all on the macOS version of BetterDiscord.

To Reproduce Build and inject BetterDiscord from master on macOS and try to open either CSS editor. Nothing will happen.

Expected behavior The custom editor window should open when you press its button, and the CSS file should open in the system editor when you press the other button.

Screenshots image

System information MacOS Mojave, mainline Discord, BetterDiscord built from master yesterday.

Are you willing and able to fix this? Well, if somebody could tell me where BetterDiscord stores the CSS file I could open it in my system editor myself to work around it, assuming the "Recompile" button works. Or maybe this is a recent known issue and somebody can point me to an earlier commit where those buttons worked. Other than that, I have no idea what's wrong so I suppose not.

Sorry for bothering you guys so much, but when I'm forced to use Discord for community management I like to use CSS edits to shrink the sidebar and make the chat text not light grey on white in the light theme and I recently had to switch to macOS for work purposes. This project is a perfect solution on Windows but I've been having some issues getting it working properly on macOS. Thanks!

HYPExMon5ter commented 5 years ago

The System Editor button doesn’t work for me but the Custom Editor does, I’m on windows 10 though.

FrobtheBuilder commented 5 years ago

Yeah I only ever used the custom editor when I was on Windows and it worked fine. Doesn't open on macOS though.

FrobtheBuilder commented 5 years ago

Some additional information, when you press the custom editor button this error appears in the console: image Is this package.json being left out of the build or did I miss some required step building or something? It looks like there's a package.json in the editor directory, but not editor/dist

FrobtheBuilder commented 5 years ago

If I copy that outer package.json to the dist directory, a white window pops up instead of nothing happening, but the contents are totally missing. image No errors show up in the console either.

FrobtheBuilder commented 5 years ago

Yeah, running build_editor doesn't work either, I think something about the configuration is just wrong. It's expecting some package.json in the dist directory but the top level one in the built editor isn't the right one or something.

FrobtheBuilder commented 5 years ago

Eureka! I got it to work by copying the package.json and changing the "main" property from "dist/editor.js" to "editor.js". It looks like the application isn't following the node module resolution spec and searching for the package.json only in the dist directory instead of walking up the directory tree to the one above.

The build process should probably be aware of this and copy a fixed package.json into that dist directory, or it could be fixed on the app side by allowing it to walk up the tree to find the file, in accordance with the node module resolution strategy.