iamdario
commented
5 months ago In the process of preparing for the first release, I have found and fixed multiple bugs. These bugs will be fixed once this branch is merged with main. The bugs found were:
- Using standard if statements rather than hash if statements to determine whether the physical button is used
- Bug that caused no sounds to be output unless an effect was active due to using an OR statement instead of an AND
- Bug that caused multiple effects to not be layered on top of each other. Instead, it was found that only the final effect added would be applied an all other effects were ignored. This seemed to slip past for so long due to us only having two effects and therefore did not often test using multiple effects
Once these bug fixes and general improvements have been confirmed to work on the RPI, this branch will be immediately merged back into main to fix the issues mentioned above.
Now that main has been merged to include all components necessary for basic functionality, we will progress our first release. The code could, however, use some cleaning up before this release is finalised.
This release will include a basic functioning guitar pedal without the addition of a digital guitar pedal in the GUI. This will be a feature to release in a later version. Any additional effects will also be released in future versions.