search

Jsitech / JShielder

Hardening Script for Linux Servers/ Secure LAMP-LEMP Deployer/ CIS Benchmark
GNU General Public License v3.0
753 stars 241 forks source link

Refactor to Use Functions and Conditional Execution #40

Open newnix opened 4 years ago

newnix commented 4 years ago

As mentioned here, bring in several improvements to the flow of execution, making sure that directory changes are done in subshells, certain subshells are more streamlined, several calls to echo are replaced with printf, core logic is encapsulated inside new main() functions and notes on continued improvements are made in comments where the changes would require more time or deeper understanding regarding how the script functions.

Jsitech commented 4 years ago

Wow, lots of changes.. Will test out and merge..... Thanks for the contribution.

egberts commented 2 years ago

Core logic under bash function main() is also detailed in Google Shell Style Guide document.

https://google.github.io/styleguide/shellguide.html

Sibbern commented 2 years ago

Tak for hurtigt svar.

Håber i løser det hurtigt da jeg har et par kunder der er meget sure

Mvh

Fra: Egbert @.> Sendt: 29. marts 2022 14:30 Til: Jsitech/JShielder @.> Cc: Subscribed @.***> Emne: Re: [Jsitech/JShielder] Refactor to Use Functions and Conditional Execution (#40)

Core logic under bash function main() is also detailed in Google Shell Style Guide document.

https://google.github.io/styleguide/shellguide.html

— Reply to this email directly, view it on GitHub https://github.com/Jsitech/JShielder/pull/40#issuecomment-1081810611 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AIRAY7QKUEDL6XWO6GA3AADVCLZSZANCNFSM4PFL4GNQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>