search

JsonApiClient / json_api_client

Build client libraries compliant with specification defined by jsonapi.org
MIT License
362 stars 186 forks source link

Relax faraday and faraday_middleware version #364

Closed sikachu closed 4 years ago

sikachu commented 4 years ago

Hello!

Faraday and faraday_middleware has recently gone 1.0:

We want to upgrade a few gems on our project to the latest version, but found out that there's a dependency conflict because json_api_client has strict faraday and faraday_middleware requirement.

The API hasn't changed much since 0.9 -> 1.0, and the test still pass, so I think we should be good to go.

Please let me know if you have any questions or feedback about this PR. Thank you!

rahearn commented 4 years ago

Can this be merged? The TravisCI tests passed, not sure why the status check hasn't updated.

omarsotillo commented 4 years ago

Hi @lcpriest @gaorlov! 👋 We found the same situation on our environments.

Could you help on the review here? 👯

Thanks for the cool gem 💎

lcpriest commented 4 years ago

I'm not 100% on this, we might need a minor version update.

Thoughts @gaorlov?

rahearn commented 4 years ago

FWIW, I'm using this branch in production and it seems to be working fine.

gaorlov commented 4 years ago

Thanks do much for the contribution! It looks like 0.17 -> 1.0 is additive. Can you confirm that there are no breaking changes and I'll merge it in.

Thanks!

Greg

sikachu commented 4 years ago

@gaorlov sorry for the delay.

Yes, 0.17 -> 1.0 is just an additive change. We are using this in production and we found no breaking changes.

Please feel free to merge in at your convenience. Thanks!

iMacTia commented 4 years ago

@gaorlov I can confirm what was already said, when we worked on Faraday 1.0 the aim was to make it backwards-compatible with versions 0.17.x, and we postponed all the breaking changes to v2.0 That said, we took some freedom dropping a few old Rubies and updated some gems, but if your tests suite is all green then it shouldn't be an issue.

I've just found this gem and I think it makes a great use of Faraday, so I'd love to see this PR merged

gaorlov commented 4 years ago

@sikachu @rahearn @omarsotillo @lcpriest @iMacTia 1.17.0 is now in live. Thanks for your contributions and patience!

iMacTia commented 4 years ago

Legend 🎉 !