search

JsonApiClient / json_api_client

Build client libraries compliant with specification defined by jsonapi.org
MIT License
361 stars 186 forks source link

Merge upstream #366

Closed JamesGlover closed 4 years ago

JamesGlover commented 4 years ago

So as part of improving the performance/readability of the limber factories I looked at bringing in some upstream changes in json_client_api into the sanger fork. Currently validating everything with the integration suite, but looking good so far. Changes in a separate branch for the moment https://github.com/sanger/json_api_client/tree/merge_upstream This mostly brings in: @khelwood addition of raising Errors::Gone for a 410 Addition of handling of filters and other scopes on has_many relationships (Still not in upstream. The original fix I pulled in here needed to be fixed up following the merge, but seems to be working now) It does NOT include @jbeast changes where a 4xx will raise Errors::BadRequest this is because similar behaviour has now been integrated upstream, although the excpetion is Errors::ClientError

JamesGlover commented 4 years ago

Whoops, my apologies. This was supposed to go into our fork.