search

JsonApiClient / json_api_client

Build client libraries compliant with specification defined by jsonapi.org
MIT License
361 stars 186 forks source link

bigdecimal 2 support #370

Closed dpep closed 4 years ago

dpep commented 4 years ago

BigDecimal 2.0 no longer supports .new. looks like json_api_client uses both BigDecimal(x) and BigDecimal.new(x) - mind if we upgrade these last few calls?

sharshenov commented 4 years ago

@dpep I suppose, you are suggesting these changes because of error on upgrading to ruby 2.7.x. Could you please also add 2.7.1 entry here and exclude it from build matrix with old activesupport versions like it is done for 2.6.0?

BTW ruby 2.7 also raises deprecation warnings on kwargs for create and update methods in Requestor. Removing curly braces resolves the warning.

dpep commented 4 years ago

@sharshenov Thanks for jumping in to help! I pulled in a gem that depended on BigDecimal v2, which caused the trouble. Similarly, Ruby 2.7 ships with that version, which looks like it breaks activesupport 3 and 4 also. I updated the travis matrix per your request

Details: https://github.com/ruby/bigdecimal#which-version-should-you-select

I'll look into the create/update deprecation warning and may follow up in a separate PR if that's ok? Anything else you want to see here?

dpep commented 4 years ago

@sharshenov fixed those warning in https://github.com/JsonApiClient/json_api_client/pull/371

sharshenov commented 4 years ago

Huge thanks! I was investigating the BigDecimal problem with ruby 2.7 and was going to push my fix, but then I saw your PR :1st_place_medal:

dpep commented 4 years ago

@gaorlov : mind taking a look at this change as well? any changes you'd like to see here?

gaorlov commented 4 years ago

@dpep @sharshenov 1.17.1 is now live