search

JsonApiClient / json_api_client

Build client libraries compliant with specification defined by jsonapi.org
MIT License
362 stars 186 forks source link

Relax faraday dependency to allow 1.3.x #377

Closed bebbs closed 1 year ago

bebbs commented 3 years ago

👋 Hello, I noticed that this gem only allows Faraday versions < 1.2.0. That gem was recently updated to 1.3.0: https://rubygems.org/gems/faraday/versions/1.3.0

Would you be open to relaxing that requirement to allow the most recent version? The tests still pass for me locally.

MarcLapierre commented 3 years ago

Can we remove the minor cap altogether? If we can stick with a major version cap we can avoid a lot of problem with dependency conflicts.

gaorlov commented 3 years ago

This looks reasonable. Can you take a look at the failing test and see if it's related to the change? Thanks!

sobakasu commented 3 years ago

I tried relaxing the faraday version requirement to '~> 1' here, and then tested with Faraday 1.8.0: https://github.com/sobakasu/json_api_client/commit/bd5a63714f7c1b01764787c0494af6d459c7c78a spec tests are failing for ruby 2.2.6 and 2.3.3. I'm having trouble compiling those ruby versions on my mac m1 so hard to debug (Both 2.2.6 and 2.3.3 are past EOL)