search

JsonApiClient / json_api_client

Build client libraries compliant with specification defined by jsonapi.org
MIT License
361 stars 186 forks source link

use HashWithIndifferentAccess, instead of symbolize_keys #386

Closed tilo closed 3 years ago

tilo commented 3 years ago

use HashWithIndifferentAccess, instead of symbolize_keys

tilo commented 3 years ago

@chingor13, @gaorlov could you please review?

gaorlov commented 3 years ago

This looks great! Can you please update the changelog md? Thanks for taking the time!

ryanbahniuk commented 3 years ago

Thanks @tilo this will be a big help for us.

tilo commented 3 years ago

@gaorlov CHANGELOG is updated

gaorlov commented 3 years ago

i meant to mention this earlier: what's the thinking behind adding pry to the gemspec? The approach so far has been to try to keep the gemspec footprint to a minimum unless absolutely necessary. Do you feel that it's necessary? Thanks!

tilo commented 3 years ago

@gaorlov I only added it as a development dependency, so that anyone who is working on a pull request can use pry locally on their machine to set a breakpoint and inspect data, while they are debugging any failing tests for the PR they make for json_api_client.

pry will not be included as a dependency for any down-stream project using json_api_client

tilo commented 3 years ago

@gaorlov do you think it's good to go, or do you want me to remove pry?

gaorlov commented 3 years ago

The approach so far has been to keep the dependency footprint - both dev and release - to the minimum necessary to run and test. However, if you feel strongly that the addition of pry will benefit the gem I don't have any strong opposition to it. Again: thank you for taking the time and your contribution!

tilo commented 3 years ago

I removed pry from this PR, and added a separate PR here: https://github.com/JsonApiClient/json_api_client/pull/385

gaorlov commented 3 years ago

1.19.0 is now live with your changes. Thanks for contributing!