Allow Faraday dependency up to v2.0

JsonApiClient / json_api_client

Build client libraries compliant with specification defined by jsonapi.org

MIT License

362 stars 186 forks source link

Closed gerbal closed 2 years ago

gerbal commented 2 years ago

This PR closes #394 and allows Faraday versions up to v2.0

yuichiu416 commented 2 years ago

This works like a charm, it would be awesome if we can merge it and release an update

corsonknowles commented 2 years ago

Thank you for doing this! Any blockers on releasing this?

corsonknowles commented 2 years ago

@gaorlov What do you think of this?

tilo commented 2 years ago

@gaorlov would it be possible to get this PR merged soon? Faraday is changing their API

dpep commented 2 years ago

this is great, thanks @gerbal 🚀 any reason why we need the upper constraint, eg < 2.0 ?

gaorlov commented 2 years ago

Thanks for your contributions. 1.21.0 is now live

gaorlov commented 2 years ago

I kept it capped under 2.0, because it is unclear what breaking changes forced the major version bump