Add support for faraday 2.x

JsonApiClient / json_api_client

Build client libraries compliant with specification defined by jsonapi.org

MIT License

362 stars 186 forks source link

Add support for faraday 2.x #412

Closed lavoiesl closed 6 months ago

lavoiesl commented 11 months ago

Includes a rebased version of https://github.com/JsonApiClient/json_api_client/pull/402

Fixes https://github.com/JsonApiClient/json_api_client/issues/407

Prefix activesupport appraisals, as to not conflict with faraday appraisals
Bump the minimum Faraday requirement to 1.10 to pick up json support: https://github.com/lostisland/faraday/pull/1400
Allow Faraday 2.x, it doesn't require any more change than using 1.10's json support
Remove the obsolete ParseJson middleware
Add Faraday 1.10 and 2.x appraisals

Notice how no tests have changed

sarahsehr commented 10 months ago

@gaorlov Bump please :) Faraday 2.0 has been out for almost 2 years.

timbogit commented 7 months ago

@gaorlov Is this still being considered? My team depends heavily json_api_client as well as faraday, so we would really appreciate this being merged. 🙇

dolan commented 6 months ago

bumping again @gaorlov same situation here as @timbogit

gaorlov commented 6 months ago

Hi, folks! Sorry about the delayed response and thank you for the contributions! Quick question: what is the thinking behind removing gemfiles 5.2 and 6.0?

lavoiesl commented 6 months ago

I don't remember making a conscious decision to remove those. Looking at the commit, it looks live it was auto-removed when running the appraisal generator.

Is it possible that those are obsolete files?

gaorlov commented 6 months ago

i must admit i am not up to date on rails versions. It looks like 6.0 has reached EOL, but 6.1 is still supported. Can we bring it back and just test against 6 instead of a specific sub-version? i don't have a strong opinion on 5.2.3

gaorlov commented 6 months ago

Looking at the diff again, it does seem like an outdated file. It doesn't actually require rails, just activesupport

is there another mechanism by which we test that activesupport version?

also: looks like there's a bunch of old ruby failures. i think it's probably okay to drop ruby 2.3, 2.4, and 2.5 from the test matrix if you want to drop them from the workflow

lavoiesl commented 6 months ago

New matrix:

Ruby: 3.0, 3.1, 3.2, 3.3
Activesupport: 6.0, 6.1, 7.0, 7.1
Faraday: 1.x, 2.x

Updated the changelog as well

gaorlov commented 6 months ago

marvelous. thank you for pulling in appraisals! that's a really nice tool

lavoiesl commented 6 months ago

Oddly enough, it was there as a dependency and the configurations were there, but it wasn't being used in the tests 🤷🏼‍♂️

gaorlov commented 6 months ago

thank you for you contributions and patience! 1.23.0 is now live with your changes