search

JsonSchema-JavaUI / sf-java-ui

Json Schema Form java based library allow developers to define schema and form using field annotations
MIT License
24 stars 16 forks source link

Add $ref support for ComboBox + some optimization #77

Closed almirus closed 6 years ago

almirus commented 6 years ago

code deduplication and add $ref support for ComboBox

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.5%) to 91.134% when pulling 1a9a127b013d81393c435b5995ff54ed11c13c6c on almirus:master into 2959ba23a1eb11c5e5b5c4ece2a0aaa940dee10c on JsonSchema-JavaUI:dev.

SaifJerbi commented 6 years ago

Hi @almirus, Thanks for your contribution, Could you please update the documentation and describe the new added property ?

almirus commented 6 years ago

I do not speak English well. Examples for $ref: https://github.com/json-schema-form/angular-schema-form/blob/bd182950b78c68ac3556b399fbaf3e3ea9a33232/examples/data/jsonref.json https://github.com/json-schema-form/json-schema-form-core/issues/1

It may be necessary to add support $ref for all fields

SaifJerbi commented 6 years ago

I found the combo box and the check box documentation aren't published yet, so i will add this property in the doc and publish that ASAP. Don't hesitate if you find any improvement to do