Performance stats - Githubissues

Ju1-js / 25th-hour-dynamic

A dynamic port of The 25th Hour by Louis Coyle

https://ju1-js.github.io/25th-hour-dynamic/

MIT License

9 stars 1 forks source link

Performance stats #9

Closed 42Willow closed 1 year ago

42Willow commented 1 year ago

[x] INCLUDE LICENSES
[x] Toggle switch
[x] Option to change animation speed
[x] Option to change position (bottom left and bottom right corner, top left and top right is reserved for weather/date/time)
[x] Disable rendering when hidden (for settings and desktop!)
[x] Make PR #26

I'll work on this.

Ju1-js commented 1 year ago

The main reason, that I've left the settings panel in the code is for the <div class="counter"></div> to show what state the animation is in. Also all of the settings panel customization options are at the bottom so as to not be in the way...

42Willow commented 1 year ago

What about performance stats in the empty space of the settings panel? I've already got some code from the demo repo. (yes, my laptop is a potato...)

I can move this to the settings panel and try to disable the rendering when the panel is hidden for performance.

Ju1-js commented 1 year ago

If they're going to be hidden behind that panel, I'd just use task manager to see performance. (They also fit the theme quite well)

I'd just:

Make it toggle-able
Disable rendering when hidden

P.S. Don't forget the licences if there are any!

42Willow commented 1 year ago

So you think that they should just be on the main desktop or under the side panel?

Yep, I'll remember those licences.

Ju1-js commented 1 year ago

Yea, just on the main desktop, otherwise they're kinda pointless.

42Willow commented 1 year ago

Ju1-js commented 1 year ago

Merged!