JuBiotech / peak-performance

A Python toolbox for Bayesian inference of peak areas.
https://peak-performance.readthedocs.io/en/latest
GNU Affero General Public License v3.0
4 stars 1 forks source link

Improve first user experience #31

Open Adafede opened 4 days ago

Adafede commented 4 days ago

Dear @Y0dler, and @michaelosthege

I have been assigned to review your repository for https://github.com/openjournals/joss-reviews/issues/7313.

As this is my first issue, please be ensured I highly appreciate a lot of points that are already available. Per convenience, I will not list all the things that are already done well, but only the "issues" so this might give a way more negative impression than what my real thoughts are, my apoogies for it already!

Y0dler commented 1 day ago

By basic steps, do you refer just to the installation instructions?

I updated the about section with the link to the documentation and changed the landing page of the docu to contain all installation instructions in a new PR (see #35).

Adafede commented 1 day ago

Yes, you adressed everything except the example time and intensity arrays in #35 😊

Y0dler commented 16 hours ago

Just replaced the markdown file with a Jupyter notebook which shows how to open a *.npy file (although I guess this was also covered in some of the other notebooks) and then gives an example of an actual metabolite and a random time series showing how the raw data file would have to be named and how it can be stored. Is this sufficient?

Adafede commented 14 hours ago

@Y0dler Perfect, it will probably help a lot of beginners 😉

Adafede commented 14 hours ago

I let you merge and close 👍🏼