JuDFTteam / aiida-fleur

AiiDA plugin of the high-performance density functional theory code FLEUR (www.judft.de) for high-throughput electronic structure calculations.
https://aiida-fleur.readthedocs.io
Other
14 stars 7 forks source link

Supporting fleur MaXR5 while supporting MaXR4 #104

Closed broeder-j closed 3 years ago

broeder-j commented 3 years ago

Ideally we would like to support both versions at the same time. This should be feasible with the xpath generation from the schema files in masci-tools. If you find an issue please add it to the list

Here I collect things which changed or are broken:

Calculations:

Parsers:

FleurinpData:

Fleurinpmodifier:

Tools:

Workchains: Simple tests parse, workchains run, but it still needs to be checked if all values are there and if all paths taken are correct

janssenhenning commented 3 years ago

get_parameter_data can now handle the exchange and correlation potential again, but the electron configuration is still disabled at the moment

janssenhenning commented 3 years ago

To make the band and dos wc work for both versions we would probably need to restrict ndir to not be -2 for the old version, since this changes the fleur behaviour to drastically

janssenhenning commented 3 years ago

I would tentatively close this for now. The only place, where I think issues could still pop up is the electronic configuration extraction but I think if this fails somewhere it will fail for both Max4 and Max5 I think. Feel free to reopen if new issues pop up regarding this