search

JuDFTteam / aiida-fleur

AiiDA plugin of the high-performance density functional theory code FLEUR (www.judft.de) for high-throughput electronic structure calculations.
https://aiida-fleur.readthedocs.io
Other
14 stars 7 forks source link

Merge develop into master for new release v.1.2.0 #126

Closed broeder-j closed 3 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #126 (cac7ddf) into master (8ef56cb) will decrease coverage by 2.44%. The diff coverage is 53.86%.

:exclamation: Current head cac7ddf differs from pull request most recent head 37bae04. Consider uploading reports for the commit 37bae04 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   68.57%   66.12%   -2.45%     
==========================================
  Files          71      119      +48     
  Lines       10501    12434    +1933     
==========================================
+ Hits         7201     8222    +1021     
- Misses       3300     4212     +912
Impacted Files Coverage Δ
aiida_fleur/common/defaults.py 0.00% <ø> (ø)
aiida_fleur/common/node_generators.py 0.00% <0.00%> (ø)
aiida_fleur/workflows/ssdisp_conv.py 23.62% <ø> (ø)
tests/calculation/test_inpgen.py 85.18% <ø> (ø)
tests/conftest.py 70.13% <ø> (ø)
tests/data/test_fleurinp.py 100.00% <ø> (ø)
tests/data/test_fleurinpmodifier.py 100.00% <ø> (ø)
tests/parsers/test_fleur_parser.py 96.22% <ø> (ø)
tests/test_calcfunctions_immutabledefaults.py 92.00% <ø> (ø)
tests/test_entrypoints.py 100.00% <ø> (ø)
... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8ef56cb...37bae04. Read the comment docs.

broeder-j commented 3 years ago

I do not understand the current error in the CI with the docs build. Locally I have no problems. But there I also have a different python version...

Readthedocs builds fine ignores this exception. But the sphinx-click extension is not working there for the CLI

janssenhenning commented 3 years ago

@broeder-j Simply adding reentry scan seems to help. I would also switch the docs build to python 3.8, since I had some problems with python 3.7 and sphinx 4.0 for masci-tools. For example unordered lists are not shown correctly (e.g https://aiida-fleur.readthedocs.io/en/latest/devel_guide/dg_index.html)

EDIT: Problem is I don't know how you would add the reentry scan to the read the docs build, since it does not really support arbitrary commands (But we can probably access reentry scan via python directly in the conf.py file)

broeder-j commented 3 years ago

@janssenhenning Thx