janssenhenning commented 3 years ago

This pre-commit hook transforms format strings and percent formatted strings to f-strings

I looked over the changes and could not find a place where the change would matter (for example it makes a difference I think whether a percent formatted string or an format/f-string is passed to a logger)

codecov[bot] commented 3 years ago

Codecov Report

Merging #141 (35ae5d2) into develop (ee8e812) will not change coverage. The diff coverage is 45.81%.

@@           Coverage Diff            @@
##           develop     #141   +/-   ##
========================================
  Coverage    64.49%   64.49%           
========================================
  Files          120      120           
  Lines        13298    13298           
========================================
  Hits          8577     8577           
  Misses        4721     4721

Impacted Files	Coverage Δ
aiida_fleur/common/workchain/utils.py	`95.23% <0.00%> (ø)`
aiida_fleur/data/fleurinp.py	`89.41% <0.00%> (ø)`
aiida_fleur/tools/dict_util.py	`79.68% <0.00%> (ø)`
aiida_fleur/tools/extract_corelevels.py	`84.81% <0.00%> (ø)`
aiida_fleur/tools/plot/fleur.py	`55.13% <0.00%> (ø)`
aiida_fleur/workflows/base_relax.py	`29.16% <ø> (ø)`
aiida_fleur/workflows/mae_conv.py	`25.80% <0.00%> (ø)`
aiida_fleur/workflows/optimize_para.py	`31.18% <0.00%> (ø)`
aiida_fleur/workflows/orbcontrol.py	`12.52% <0.00%> (ø)`
aiida_fleur/workflows/ssdisp_conv.py	`23.62% <0.00%> (ø)`
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ee8e812...35ae5d2. Read the comment docs.

janssenhenning commented 3 years ago

Notice this solves not all the f-string complaints of pylint, mainly because of implicitly joined strings over multiple lines but it's a start

JuDFTteam / aiida-fleur

Add flynt hook to pre-commit #141

Codecov Report