search

JuDFTteam / aiida-fleur

AiiDA plugin of the high-performance density functional theory code FLEUR (www.judft.de) for high-throughput electronic structure calculations.
https://aiida-fleur.readthedocs.io
Other
14 stars 7 forks source link

Deprecate `rel_to_abs`, `rel_to_abs_f`, `abs_to_rel` and `abs_to_rel_f` #179

Closed janssenhenning closed 2 years ago

janssenhenning commented 2 years ago

These functions are completely covered in masci_tools.io.common_functions Replaced function bodies with just calling the masci-tools functions

codecov[bot] commented 2 years ago

Codecov Report

Merging #179 (1ab240b) into develop (8823487) will increase coverage by 1.25%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #179      +/-   ##
===========================================
+ Coverage    70.97%   72.23%   +1.25%     
===========================================
  Files          121      121              
  Lines        14766    16267    +1501     
===========================================
+ Hits         10480    11750    +1270     
- Misses        4286     4517     +231
Impacted Files Coverage Δ
aiida_fleur/tools/StructureData_util.py 76.92% <100.00%> (+1.08%) :arrow_up:
tests/conftest.py 92.68% <100.00%> (+0.60%) :arrow_up:
tests/tools/test_StructureData_util.py 99.21% <100.00%> (+0.02%) :arrow_up:
aiida_fleur/workflows/base_relax.py 19.67% <0.00%> (-0.22%) :arrow_down:
aiida_fleur/calculation/fleur.py 72.70% <0.00%> (-0.09%) :arrow_down:
aiida_fleur/workflows/create_magnetic_film.py 16.30% <0.00%> (-0.06%) :arrow_down:
tests/tools/test_common_fleur_wf.py 100.00% <0.00%> (ø)
aiida_fleur/tools/common_fleur_wf_util.py 96.16% <0.00%> (+0.12%) :arrow_up:
aiida_fleur/cmdline/util/defaults.py 93.33% <0.00%> (+0.15%) :arrow_up:
aiida_fleur/tools/common_aiida.py 98.85% <0.00%> (+0.41%) :arrow_up:
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8823487...1ab240b. Read the comment docs.