JuDFTteam / aiida-fleur

AiiDA plugin of the high-performance density functional theory code FLEUR (www.judft.de) for high-throughput electronic structure calculations.
https://aiida-fleur.readthedocs.io
Other
14 stars 7 forks source link

Add mypy type checking to pre-commit #201

Closed janssenhenning closed 1 year ago

janssenhenning commented 1 year ago

The type-checking is opt-in and only a few files are type checked for now

codecov[bot] commented 1 year ago

Codecov Report

Base: 77.16% // Head: 77.55% // Increases project coverage by +0.39% :tada:

Coverage data is based on head (191a30f) compared to base (bfca31b). Patch coverage: 88.69% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## support/aiida-2.X #201 +/- ## ===================================================== + Coverage 77.16% 77.55% +0.39% ===================================================== Files 114 122 +8 Lines 14852 15409 +557 ===================================================== + Hits 11460 11951 +491 - Misses 3392 3458 +66 ``` | [Impacted Files](https://codecov.io/gh/JuDFTteam/aiida-fleur/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuDFTteam) | Coverage Δ | | |---|---|---| | [aiida\_fleur/tools/StructureData\_util.py](https://codecov.io/gh/JuDFTteam/aiida-fleur/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuDFTteam#diff-YWlpZGFfZmxldXIvdG9vbHMvU3RydWN0dXJlRGF0YV91dGlsLnB5) | `75.13% <0.00%> (ø)` | | | [aiida\_fleur/tools/bfgs.py](https://codecov.io/gh/JuDFTteam/aiida-fleur/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuDFTteam#diff-YWlpZGFfZmxldXIvdG9vbHMvYmZncy5weQ==) | `94.84% <ø> (ø)` | | | [aiida\_fleur/tools/straight\_torque.py](https://codecov.io/gh/JuDFTteam/aiida-fleur/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuDFTteam#diff-YWlpZGFfZmxldXIvdG9vbHMvc3RyYWlnaHRfdG9ycXVlLnB5) | `0.00% <ø> (ø)` | | | [aiida\_fleur/workflows/relax\_torque.py](https://codecov.io/gh/JuDFTteam/aiida-fleur/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuDFTteam#diff-YWlpZGFfZmxldXIvd29ya2Zsb3dzL3JlbGF4X3RvcnF1ZS5weQ==) | `58.93% <ø> (ø)` | | | [aiida\_fleur/tools/xml\_aiida\_modifiers.py](https://codecov.io/gh/JuDFTteam/aiida-fleur/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuDFTteam#diff-YWlpZGFfZmxldXIvdG9vbHMveG1sX2FpaWRhX21vZGlmaWVycy5weQ==) | `83.33% <83.33%> (-4.17%)` | :arrow_down: | | [aiida\_fleur/data/fleurinp.py](https://codecov.io/gh/JuDFTteam/aiida-fleur/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuDFTteam#diff-YWlpZGFfZmxldXIvZGF0YS9mbGV1cmlucC5weQ==) | `89.43% <88.79%> (+0.13%)` | :arrow_up: | | [aiida\_fleur/data/fleurinpmodifier.py](https://codecov.io/gh/JuDFTteam/aiida-fleur/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuDFTteam#diff-YWlpZGFfZmxldXIvZGF0YS9mbGV1cmlucG1vZGlmaWVyLnB5) | `95.89% <100.00%> (-0.05%)` | :arrow_down: | | [tests/conftest.py](https://codecov.io/gh/JuDFTteam/aiida-fleur/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuDFTteam#diff-dGVzdHMvY29uZnRlc3QucHk=) | `87.81% <100.00%> (ø)` | | | [tests/tools/test\_plot\_fleur.py](https://codecov.io/gh/JuDFTteam/aiida-fleur/pull/201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuDFTteam#diff-dGVzdHMvdG9vbHMvdGVzdF9wbG90X2ZsZXVyLnB5) | `93.06% <100.00%> (-6.94%)` | :arrow_down: | | ... and [9 more](https://codecov.io/gh/JuDFTteam/aiida-fleur/pull/201?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuDFTteam) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuDFTteam). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuDFTteam)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.