Compile and use jpsreport on windows

JuPedSim / jpsreport

Analysis tool

https://www.jupedsim.org/jpsreport_introduction.html

Other

3 stars 9 forks source link

Compile and use jpsreport on windows #144

Closed xuqiancheng closed 5 years ago

xuqiancheng commented 5 years ago

ba4e776 Fix some problems when compiling jpsreport on windows with VS2017. Problem related with OpenMP and link with stdc++fs( it seems that we dont't have to link stdc++fs when compile with MSVC).
937c3c6 Since the difference between '/' and '\', there are some errors when using jpsreport on windows. I have fixed these errors, now it works good on my computer, but the code need to be tested on another windows and on other OS.

gjaeger commented 5 years ago

ba4e776 I don't get an error message (see cmake_protocol.log). We should always check the cmake file, like jpscore.
937c3c6 I get your changes now as a warning (see make_protocol.log). We should not only solve this problem for one operating system.

xuqiancheng commented 5 years ago

@gjaeger Yes, I agree with you. We should check the cmake file, like jpscore. I have made some mistakes, 42937b3 fixed it. And I have tested it on manjaro, it works without warning. Could you test it on your OS, thanks.

chraibi commented 5 years ago

I can compile this and run basic tests. It looks good. @gjaeger unless you have any concerns, I think this should be accepted and merged.

gjaeger commented 5 years ago

No concerns. We can merge.