Closed xuqiancheng closed 5 years ago
@gjaeger Yes, I agree with you. We should check the cmake file, like jpscore. I have made some mistakes, 42937b3 fixed it. And I have tested it on manjaro, it works without warning. Could you test it on your OS, thanks.
I can compile this and run basic tests. It looks good. @gjaeger unless you have any concerns, I think this should be accepted and merged.
No concerns. We can merge.
ba4e776 Fix some problems when compiling jpsreport on windows with VS2017. Problem related with OpenMP and link with stdc++fs( it seems that we dont't have to link stdc++fs when compile with MSVC).
937c3c6 Since the difference between '/' and '\', there are some errors when using jpsreport on windows. I have fixed these errors, now it works good on my computer, but the code need to be tested on another windows and on other OS.