search

JuPedSim / jpsreport

Analysis tool
https://www.jupedsim.org/jpsreport_introduction.html
Other
3 stars 9 forks source link

git branch, revision, date and compile information #51

Closed chraibi closed 5 years ago

chraibi commented 5 years ago

In Gitlab by @gjaeger on May 9, 2018, 10:10 [origin]

Extract from a logfile:

INFO:   Parsing the ini file <ini_UNI_CORR_500_09.xml>
INFO:   Geometry File is: <./geo_UNI_CORR_500_09.xml>
INFO:   Format of the trajectory file is: <.txt>
INFO:   Input trajectory file is    <traj_UNI_CORR_500_09.txt>

Can we add the following information to the logfile?

It could simplify debugging.

chraibi commented 5 years ago

In Gitlab by @chraibi on May 13, 2018, 23:40

First try

Screen_Shot_2018-05-14_at_01.10.31

See cc43b9d5

Compiler information? Like what?

chraibi commented 5 years ago

In Gitlab by @gjaeger on May 14, 2018, 09:13

assigned to @chraibi

chraibi commented 5 years ago

In Gitlab by @gjaeger on May 14, 2018, 09:23

Thanks.

These are the first lines (commit 88fd8c3)

INFO:   COMPILER : clang++ 9.1.0
----
INFO:   COMMIT   : v0.8.2-36-g88fd8c3
INFO:   DATE     : Mon May 14 08:43:23 2018
INFO:   SUBJECT  : Add compiler infos
INFO:   BRANCH   : issue_79
----
INFO:   Parsing the ini file <ini_UNI_CORR_500_09.xml>
INFO:   Geometry File is: <./geo_UNI_CORR_500_09.xml>
INFO:   Format of the trajectory file is: <.txt>
INFO:   Input trajectory file is    <traj_UNI_CORR_500_09.txt>

Q: Does the sign g in v0.8.2-36-g88fd8c3 have meaning?

INFO:   COMMIT   : v0.8.2-36-g88fd8c3

Can we add/change the following lines/information?

----
INFO:   CURRENT DATE  :
INFO:   VERSION       :
INFO:   COMMIT        : 
INFO:   COMMIT DATE   : 
INFO:   COMPILER      : 
INFO:   COMPILER DATE : 
----
chraibi commented 5 years ago

In Gitlab by @chraibi on May 14, 2018, 09:40

Screen_Shot_2018-05-14_at_09.40.01

chraibi commented 5 years ago

In Gitlab by @chraibi on May 14, 2018, 09:44

Gregor I don't know what the g in the commit hash means :thinking:

chraibi commented 5 years ago

In Gitlab by @chraibi on May 14, 2018, 09:50

The "g" prefix stands for "git" and is used to allow describing the version of a software depending on the SCM the software is managed with. This is useful in an environment where people may use different SCMs.

from documentation

chraibi commented 5 years ago

In Gitlab by @gjaeger on May 14, 2018, 09:54

Do we need the line Commit subject?

The Version and the Commit hash show different version numbers. Is this ok?

chraibi commented 5 years ago

In Gitlab by @chraibi on May 14, 2018, 09:55

chraibi commented 5 years ago

In Gitlab by @gjaeger on May 14, 2018, 09:57

Thanks. I am perfectly happy. You can make a pull request.

chraibi commented 5 years ago

In Gitlab by @chraibi on May 14, 2018, 13:22

created branch 79-git-branch-revision-date-and-compile-information

chraibi commented 5 years ago

In Gitlab by @chraibi on May 14, 2018, 13:22

mentioned in merge request !6

chraibi commented 5 years ago

In Gitlab by @gjaeger on May 14, 2018, 19:28

with commit 38c804fc, I get the following message:

$ make -j2
/Users/gjaeger/Documents/hubs/JuPedSim_dev/jpsreport/IO/OutputHandler.cpp:60:10: warning: 'this' pointer cannot be null in well-defined C++ code;
      comparison may be assumed to always evaluate to true [-Wtautological-undefined-compare]
     if (this != NULL)
         ^~~~    ~~~~
/Users/gjaeger/Documents/hubs/JuPedSim_dev/jpsreport/IO/OutputHandler.cpp:159:10: warning: 'this' pointer cannot be null in well-defined C++ code;
      comparison may be assumed to always evaluate to true [-Wtautological-undefined-compare]
     if (this != NULL) {
         ^~~~    ~~~~
2 warnings generated.
In file included from /Users/gjaeger/Documents/hubs/JuPedSim_dev/jpsreport/general/ArgumentParser.cpp:37:
/Users/gjaeger/Documents/hubs/JuPedSim_dev/jpsreport/general/../.vs/dirent.h:19:10: fatal error: 'windows.h' file not found
#include <windows.h>
         ^~~~~~~~~~~
1 error generated.
make[2]: *** [CMakeFiles/geometrycore.dir/general/ArgumentParser.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/geometrycore.dir/all] Error 2
chraibi commented 5 years ago

In Gitlab by @chraibi on May 14, 2018, 20:12

Should be fixed with de0fc2be

chraibi commented 5 years ago

In Gitlab by @gjaeger on May 14, 2018, 20:49

ok, only two warnings:

$ make -j2
Scanning dependencies of target geometrycore
[  7%] Building CXX object CMakeFiles/geometrycore.dir/IO/OutputHandler.cpp.o
[  7%] Building CXX object CMakeFiles/geometrycore.dir/Analysis.cpp.o
/Users/gjaeger/Documents/hubs/JuPedSim_dev/jpsreport/IO/OutputHandler.cpp:60:10: warning: 'this' pointer cannot be null in well-defined C++ code;
      comparison may be assumed to always evaluate to true [-Wtautological-undefined-compare]
     if (this != NULL)
         ^~~~    ~~~~
/Users/gjaeger/Documents/hubs/JuPedSim_dev/jpsreport/IO/OutputHandler.cpp:159:10: warning: 'this' pointer cannot be null in well-defined C++ code;
      comparison may be assumed to always evaluate to true [-Wtautological-undefined-compare]
     if (this != NULL) {
         ^~~~    ~~~~
2 warnings generated.
[ 10%] Building CXX object CMakeFiles/geometrycore.dir/general/ArgumentParser.cpp.o
chraibi commented 5 years ago

In Gitlab by @gjaeger on May 14, 2018, 20:53

looks good (with de0fc2be):

JuPedSim - JPSreport

Current date   : May 14 2018 20:52:51
Version        : 0.8.3
Compiler       : clang++ (9.1.0)
Commit hash    : v0.8.2-69-gccd63ad
Commit date    : Mon May 14 20:22:15 2018
Branch         : issue_79
chraibi commented 5 years ago

In Gitlab by @gjaeger on May 14, 2018, 21:00

but ...

... I get a Segmentation fault: 11 with UNI_CORR_500_09.zip (complete log)

chraibi commented 5 years ago

In Gitlab by @chraibi on May 15, 2018, 08:57

same like #81?

chraibi commented 5 years ago

In Gitlab by @gjaeger on May 15, 2018, 08:57

I don't know.

chraibi commented 5 years ago

In Gitlab by @PaulGeoerg on May 15, 2018, 10:05

@chraibi : Any possibility to write out a log on a win-maschine?

chraibi commented 5 years ago

In Gitlab by @gjaeger on May 15, 2018, 11:15

JuPedSim - JPSreport

Current date   : May 15 2018 11:12:36
Version        : 0.8.3
Compiler       : clang++ (9.1.0)
Commit hash    : v0.8.2-70-ge26550b
Commit date    : Tue May 15 10:15:13 2018
Branch         : develop

same problem with commit e26550b4: I get a segmentation fault: 11

INFO:   Measurement area id <2> will be used for analysis
INFO:   Individual FD will be output
INFO:   Each Voronoi cell will be cut by a circle with the radius of < 1.000000 > m!!
INFO:   The circle is discretized to a polygon with < 10> edges!!
INFO:   Data of voronoi diagram is asked to output
Segmentation fault: 11
chraibi commented 5 years ago

In Gitlab by @chraibi on May 15, 2018, 15:04

Gregor check out 24f0abbd

I'm closing this issue now.

chraibi commented 5 years ago

In Gitlab by @chraibi on May 15, 2018, 15:04

closed

chraibi commented 5 years ago

In Gitlab by @gjaeger on May 15, 2018, 15:14

We should not close an issue until we have tested it.

chraibi commented 5 years ago

In Gitlab by @gjaeger on May 15, 2018, 15:14

reopened

chraibi commented 5 years ago

In Gitlab by @gjaeger on May 15, 2018, 15:14

I'm testing right now.

chraibi commented 5 years ago

In Gitlab by @gjaeger on May 15, 2018, 15:20

Ok, it works with commit 24f0abb (logfile).

Now, you can close the issue. :grinning:

chraibi commented 5 years ago

In Gitlab by @chraibi on May 15, 2018, 15:20

:+1:

chraibi commented 5 years ago

In Gitlab by @chraibi on May 15, 2018, 15:20

closed