JuPedSim / jpsreport

Analysis tool
https://www.jupedsim.org/jpsreport_introduction.html
Other
3 stars 9 forks source link

Method D is too slow #53

Closed chraibi closed 5 years ago

chraibi commented 5 years ago

In Gitlab by @chraibi on May 19, 2018, 08:36 [origin]

See Paul's last comment in #81

chraibi commented 5 years ago

In Gitlab by @chraibi on May 19, 2018, 09:18

I tried this with these files files_82_report.zip

This is my result

Screen_Shot_2018-05-19_at_09.13.52

It does not look terribly slow. Here of course without plotting activated.

Time elapsed:    2.69 [s]

Can you measure your execution time?

chraibi commented 5 years ago

In Gitlab by @PaulGeoerg on May 19, 2018, 10:21

Hmmm, looks quite good. I don't know why my try is so terrible slow. I will check this again this weekend or on thuesday.

chraibi commented 5 years ago

In Gitlab by @chraibi on May 19, 2018, 13:35

changed time estimate to 1w

chraibi commented 5 years ago

In Gitlab by @PaulGeoerg on May 22, 2018, 08:36

Okay, seems to be something wrong with my modificiations of the plotting scripts. I don't know what is happend in detail because it works quite good with v.0.8.2, but using the oiginal ones looks quite good:

----
JuPedSim - JPSreport

Current date   : May 20 2018 04:31:56
Version        : 0.8.3
Compiler       : Visual Studio (1911.191125547.0)
Commit hash    : v0.8.2-73-ga605388
Commit date    : Tue May 15 15:03:28 2018
Branch         : develop
----

INFO:   Parsing the ini file <.\ini_report.xml>
INFO:   logfile <./log.txt>
INFO:   Success with Method D using measurement area id 2
INFO:   Plotting time series of density and velocity from trajectory <1501_converted.txt>
INFO:   End Analysis for the file: 1501_converted.txt
Time elapsed:    79.3648 [s]

But and maybe a new issue (?): It may be usefull to have a bit information about the progress in the terminal?

Another issue: enabling method b gives a lot detailed printouts like i: 59, Tin: 1036, Tout: 1214, PointIn (-1.9924, -0.4658), PointOut (0.0179, -0.2557), L: 2

in the terminal. This may be compressed like a status e.g. ped_in : ped_put ?

Overall, I measured execution time for all four method (plotting activated, profiles=false, output voro-cells-false) by `Time elapsed: 119.032 [s]

which is absolutely sufficient. Thanks, Mohcine!

So: close the issue and open a new one for remove printouts and status-information in the terminal?

chraibi commented 5 years ago

In Gitlab by @chraibi on Jun 21, 2018, 10:49

Is this still an issue?

chraibi commented 5 years ago

In Gitlab by @PaulGeoerg on Jun 21, 2018, 10:53

No, in my case everything is finished. Thanks, Mohcine!

chraibi commented 5 years ago

In Gitlab by @chraibi on Jun 21, 2018, 10:55

closed