JuPedSim / jpsreport

Analysis tool
https://www.jupedsim.org/jpsreport_introduction.html
Other
3 stars 9 forks source link

scripts | plot voronoi-cells #54

Closed chraibi closed 5 years ago

chraibi commented 5 years ago

In Gitlab by @PaulGeoerg on Jun 6, 2018, 10:17 [origin]

Something went wrong if plot voronoi-graphs is set "true" (method D) (see the log-file attached).

I get the following error-info:

INFO: python C:/Users/Paul Geoerg/workspace/jpsreport/scripts//_Plot_cell_rho.py -f "././Output/Fundamental_Diagram/Classical_Voronoi/VoronoiCell/" -n 0501_converted.txt_id_2_00160 -g ././geo/BOT090_geo_truncated.xml -p ./../data/05LL/ INFO: Plotting Voronoi Cell at the frame <00160>

The polygon-files will be created immediately after the error-message. It seems that the the voronoi-polygon-files will be created after the plot-script is called? But I do not know exactly.

files_84_report.zip

chraibi commented 5 years ago

In Gitlab by @chraibi on Sep 18, 2018, 19:06

@gjaeger can you reproduce this issue?

chraibi commented 5 years ago

In Gitlab by @gjaeger on Sep 19, 2018, 07:42

This is not an issue. It's an information output.

see Method_D.cpp, line 461 ff:

     if(_plotVoronoiCellData)
     {
          string parameters_rho=" " + _scriptsLocation+"/_Plot_cell_rho.py -f \""+ voronoiLocation + "\" -n "+ _trajName+"_id_"+_measureAreaId+"_"+frameId+
               " -g "+_geometryFileName+" -p "+_trajectoryPath;
          string parameters_v=" " + _scriptsLocation+"/_Plot_cell_v.py -f \""+ voronoiLocation + "\" -n "+ _trajName+"_id_"+_measureAreaId+"_"+frameId+
               " -g "+_geometryFileName+" -p "+_trajectoryPath;

          if(_plotVoronoiIndex)
               parameters_rho += " -i";

          Log->Write("INFO:\t%s",parameters_rho.c_str());
          Log->Write("INFO:\tPlotting Voronoi Cell at the frame <%s>",frameId.c_str());
          parameters_rho = PYTHON + parameters_rho;
          parameters_v = PYTHON + parameters_v;
          system(parameters_rho.c_str());
          system(parameters_v.c_str());
     }

It's all fine.

chraibi commented 5 years ago

In Gitlab by @gjaeger on Sep 20, 2018, 08:23

summary:

The problem described is based on a space in the path (scriptsLocation):

<scripts location="C:/Users/Paul Geoerg/workspace/jpsreport/scripts/"/>

The path is not completely passed: cmd

After changing the script path, there was a problem with an obsolete python script:

err

The script was updated and then it worked.

suggestion:

@chraibi Should we review the scripts for handling paths on different operating systems (more information (in german))?

@PaulGeoerg Can we close your issue?

chraibi commented 5 years ago

In Gitlab by @PaulGeoerg on Sep 20, 2018, 08:31

Thanks for your support, @gjaeger. The issue is certainly solved and can be closed!

chraibi commented 5 years ago

In Gitlab by @PaulGeoerg on Sep 20, 2018, 08:32

closed

chraibi commented 5 years ago

In Gitlab by @chraibi on Sep 20, 2018, 09:07

Should we review the scripts for handling paths on different operating systems

@gjaeger definitely, yes.

Besides, we should do this also in C++. See #80.

Can you solve one of these issues? Or even both?

chraibi commented 5 years ago

In Gitlab by @gjaeger on Sep 20, 2018, 19:02

Besides, we should do this also in C++. See #80. Can you solve one of these issues? Or even both?

Let's talk about it on Wednesday.